Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Docker workflow to build-push-action v2 #1441

Merged
merged 26 commits into from
May 10, 2021
Merged

ci: Update Docker workflow to build-push-action v2 #1441

merged 26 commits into from
May 10, 2021
+124 −69

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 10, 2021 •
edited
Loading

Description

Update Docker workflow to use docker/login-action@v2 workflow API.

Also update the base image to python:3.8-slim.

This additionally added the GitHub related secrets:

  • DOCKERHUB_USERNAME
  • DOCKERHUB_TOKEN

which means that after this PR is merged the secrets

  • DOCKER_USERNAME
  • DOCKER_PASSWORD

should be removed from the repo.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update builder base image to python:3.8-slim
* Consolidate Docker testing and publishing workflow
   - Move out of CI workflow
   - Rename .github/workflows/publish-docker.yml -> .github/workflows/docker.yml
* Update Docker workflow to use docker/login-action@v2
   - Use update guide 
   - c.f. https://github.com/docker/build-push-action/blob/17822e4df435afa2aa88ec7d85b56ff55446ca36/UPGRADE.md
* Update Docker tagging system to be context dependent

@matthewfeickert
Add seperate Docker workflow
e6ba29c
@matthewfeickert
Update workflow to also test
1615802
@matthewfeickert
Remove docker workflow that was added
d93b569
@matthewfeickert
Add testing of images
167d990
@matthewfeickert
Remove Docker tests from CI
c7bba0a
@matthewfeickert
Add check for PR
650edef
@matthewfeickert
rename
3edf8fe
@matthewfeickert
Rename workflow to docker
760d672
@matthewfeickert
Add cron
edf31f1
@matthewfeickert
comment out push restrictions for tests
70e5c77
@matthewfeickert
make ids unique
00f6fd4
@matthewfeickert
Do releases of images on GitHub releases
595d4fd
@matthewfeickert
Use new API
7e15257
@matthewfeickert
Automatic tagging with sha no longer supported by default
b1e9522 
c.f. https://github.com/docker/build-push-action/blob/master/docs/advanced/tags-labels.md
@matthewfeickert
Use DockerHub access token
d229445
@matthewfeickert
Add QEMU to see if it matters
04d2f22
@matthewfeickert
Use path context for git scm to work
267a137 
https://github.com/docker/build-push-action#path-context
@matthewfeickert
load to local context
ea4b3be 
c.f. https://github.com/docker/buildx/blob/master/docs/reference/buildx_build.md#-load-the-single-platform-build-result-to-docker-images---load
@matthewfeickert
Set tags based off of situation
929369a
@matthewfeickert
add labels
42ba15f
@matthewfeickert
Update tags available
eb38afc 
Explains v2 workflow

c.f. https://github.com/docker/build-push-action/blob/master/UPGRADE.md
@matthewfeickert
try using sha for test tag
00b6458
@matthewfeickert
Remove refs/heads as tags
851f1fa
@matthewfeickert
Uncomment on master and tags only
55e85eb
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label May 10, 2021
@matthewfeickert matthewfeickert self-assigned this May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021 •
edited
Loading

Codecov Report

Merging #1441 (c887a71) into master (467e69f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1441   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          63       63           
  Lines        3967     3967           
  Branches      555      555           
=======================================
  Hits         3873     3873           
  Misses         55       55           
  Partials       39       39
Flag Coverage Δ
contrib 25.58% <ø> (ø)
unittests 97.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467e69f...c887a71. Read the comment docs.

@matthewfeickert matthewfeickert marked this pull request as ready for review May 10, 2021 07:45
@matthewfeickert matthewfeickert requested a review from kratsg May 10, 2021 07:45
@matthewfeickert
Copy link
Member Author

The update was pretty confusing at first, but the new workflow is actually way nicer IMO, so I think Docker did a good job here. 👍

@matthewfeickert matthewfeickert merged commit 5693d27 into master May 10, 2021
@matthewfeickert matthewfeickert deleted the ci/update-docker-ci branch May 10, 2021 15:37
@matthewfeickert matthewfeickert mentioned this pull request May 10, 2021
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request May 10, 2021
@matthewfeickert
fix: Remove load option from Docker workflow publish steps (#1442)
eaf6e05 
* Remove load from docker/build-push-action@v2 action publish steps
   - load and push can not be used in the same step
   - load option: Shorthand for --output=type=docker
* Amends PR #1441
@matthewfeickert matthewfeickert added the Docker Involving Docker images or builds label May 10, 2021
@matthewfeickert matthewfeickert mentioned this pull request May 10, 2021
Closed
@matthewfeickert
Copy link
Member Author

which means that after this PR is merged the secrets

  • DOCKER_USERNAME
  • DOCKER_PASSWORD

should be removed from the repo.

This is done now.

This was referenced May 13, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratsg kratsg Awaiting requested review from kratsg

@lukasheinrich lukasheinrich Awaiting requested review from lukasheinrich

Assignees

@matthewfeickert matthewfeickert

Labels
CI CI systems, GitHub Actions Docker Involving Docker images or builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert